Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Fix low latency #849

Merged
merged 4 commits into from
Jun 29, 2018
Merged

Fix low latency #849

merged 4 commits into from
Jun 29, 2018

Conversation

xuguangxin
Copy link
Contributor

two things done to fix low latency mode.

  1. output output-able frame immediately when we add a frame to dpb. Do not check "current poc - previous poc == 1", this will introduce problem for poc "0, 2, 4, 6, 8"
  2. add a flag VIDEO_DECODE_BUFFER_FLAG_FRAME_END to tell decoder to stop search next frame, so the decoder can decode current frame ASAP
    this fixes Decoder 'drain' functionality #844 and h264 low latency decoding #847

xuguangxin and others added 4 commits May 15, 2018 12:06
we can't depends on "(current poc - last poc) == 1" to output picture.
some stream have even poc like 0, 2, 4, 6, 8. the best way is output all
outputable poc
… end

unless we got AUD or SPS/PPS in stream, we can't know we have a frame.
but in up level, we may know we have entire frame. so we add a frame to
tell decoder about this
we can make sure one frame in, one frame out in low latency case
@jsorg71
Copy link
Contributor

jsorg71 commented May 17, 2018

It looks like h265 will have this feature too. Is that correct?

@xuguangxin
Copy link
Contributor Author

@jsorg71 , h265 may not need this.
Bitstream will carry latency indication. see checkLatency . h264 does not have this, it only checks dpb fullness.
This is why we need a flag for h264.

Copy link
Contributor

@YuJiankang YuJiankang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, lgtm

@uartie
Copy link
Contributor

uartie commented Jun 27, 2018

status?

@xuguangxin
Copy link
Contributor Author

Hi @uartie , sorry for late.

@xuguangxin xuguangxin merged commit 0067a64 into intel:apache Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decoder 'drain' functionality
5 participants