-
Notifications
You must be signed in to change notification settings - Fork 756
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SYCL][UR][L0] Fix issue with event caching causing profiling tag con…
…flicts (#16233) This commit adds a test and changes to a UR version that fixes an issue where the L0 would report old timestamp recordings for events produced for profiling tags, due to reusing of dead events. --------- Signed-off-by: Larsen, Steffen <[email protected]> Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
- Loading branch information
1 parent
6778ab7
commit df7375d
Showing
3 changed files
with
41 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
# commit e37f75ffad5ad22e96c46eb70ab1757be7cc5afc | ||
# Merge: daa0b110464c 323b37c55504 | ||
# Author: Martin Grant <martin.morrisongrant@codeplay.com> | ||
# Date: Fri Dec 6 18:03:11 2024 +0000 | ||
# Merge pull request #2379 from Bensuo/ben/coverity-fixes | ||
# Fix command_buffer coverity issues | ||
set(UNIFIED_RUNTIME_TAG e37f75ffad5ad22e96c46eb70ab1757be7cc5afc) | ||
# commit 5c10466f349b0ff303bd14b015f64bbcd0b78d7d | ||
# Merge: ffcc53b6 b7b6b557 | ||
# Author: Kenneth Benzie (Benie) <k.benzie@codeplay.com> | ||
# Date: Mon Dec 9 14:58:34 2024 +0000 | ||
# Merge pull request #2410 from steffenlarsen/steffen/fix_profiling_tag_eviction_and_caching | ||
# [L0] Fix cached and evicted timestamp recordings | ||
set(UNIFIED_RUNTIME_TAG 5c10466f349b0ff303bd14b015f64bbcd0b78d7d) |
33 changes: 33 additions & 0 deletions
33
sycl/test-e2e/Regression/profiling_tag_cached_conflicting.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// REQUIRES: aspect-ext_oneapi_queue_profiling_tag | ||
// RUN: %{build} -o %t.out | ||
// RUN: %{run} %t.out | ||
|
||
// Regression test to ensure that the adapters do not tamper (e.g. through | ||
// caching the events) the recordings. | ||
|
||
// HIP backend currently returns invalid values for submission time queries. | ||
// UNSUPPORTED: hip | ||
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/12904 | ||
|
||
// CUDA backend seems to fail sporadically for expected profiling tag time | ||
// query orderings. | ||
// UNSUPPORTED: cuda | ||
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/14053 | ||
|
||
#include <sycl/detail/core.hpp> | ||
#include <sycl/ext/oneapi/experimental/profiling_tag.hpp> | ||
|
||
int main() { | ||
sycl::queue Q{sycl::property::queue::in_order()}; | ||
|
||
uint64_t T1 = 0; | ||
for (size_t I = 0; I < 20; ++I) { | ||
sycl::event E = sycl::ext::oneapi::experimental::submit_profiling_tag(Q); | ||
uint64_t T2 = | ||
E.get_profiling_info<sycl::info::event_profiling::command_end>(); | ||
assert(T1 < T2); | ||
std::swap(T1, T2); | ||
} | ||
|
||
return 0; | ||
} |