[SYCL][Graph] Fix switch statement for Clang build #10923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the merge of intel#10789 post-commit CI is failing on clang builds: * [MacOS build](https://github.com/intel/llvm/actions/runs/5935599091/job/16094354219) * [Linux build](https://github.com/intel/llvm/actions/runs/5935599091/job/16094354500) ``` /Users/runner/work/llvm/llvm/build/include/sycl/ext/oneapi/experimental/graph.hpp:67:3: error: default label in switch which covers all enumeration values [-Werror,-Wcovered-switch-default] default: ``` Fixed by removing the default label from the `switch`, and replacing with an assert `false` afterwards, which seems consistent with other places in the sycl runtime. I haven't done a clang build yet to verify this fix.
mfrancepillois
approved these changes
Aug 22, 2023
steffenlarsen
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the merge of #10789 post-commit CI is failing on clang builds:
Fixed by removing the default label from the
switch, and replacing with an assertfalseafterwards, which seems consistent with other places in the sycl runtime.