[SYCL][Fusion] Test and document group algorithms/function support #12644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-eds
commented
Feb 7, 2024
|
Proof that local ID and group ID are invariant: This is true after #12538 |
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
approved these changes
Feb 7, 2024
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Add tests for `group_broadcast` and `permute_group_by_xor` when remapping is needed. Document support for group algorithms and functions in the kernel fusion design document. Kernel fusion supports these constructs, as local range, group id and local id do not change due to remapping. Signed-off-by: Victor Perez <[email protected]>
victor-eds
force-pushed
the
test-group-algs-remapping
branch
from
849a4aa
to
b25d8bd
Compare
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Failure of |
|
Post-commit failures: Both failures seem unrelated, the reduction test also failed in post-commit for #12693 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for
group_broadcastandpermute_group_by_xorwhen remapping is needed.Document support for group algorithms and functions in the kernel fusion design document. Kernel fusion supports these constructs, as local range, group id and local id do not change due to remapping.