[SYCL] Rewrite tests when usm_ashared_allocations not supported #3 #12668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
#12655 must be merged before this in order to have all checks succeed! |
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final PR in the series of #12636.
Refer to it for a description.
#12655 must be merged before this!
After a discussion with @AlexeySachkov we've decided its best to not rewrite USM and syclcompat tests with buffers/accessors. For USM, the reason is obvious and for syclcompat you can reach out to Alexey. Therefore, these tests are handled using if statements or requring aspect to be supported.