[SYCL][Graph] Bump UR commit to OpenCL kernel update #12724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
force-pushed
the
ewan/opencl_update_ur_bump
branch
from
bed00de
to
a5e4e89
Compare
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
force-pushed
the
ewan/opencl_update_ur_bump
branch
from
a5e4e89
to
feef724
Compare
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
force-pushed
the
ewan/opencl_update_ur_bump
branch
from
feef724
to
952e167
Compare
EwanC
force-pushed
the
ewan/opencl_update_ur_bump
branch
from
952e167
to
ac1eee4
Compare
EwanC
force-pushed
the
ewan/opencl_update_ur_bump
branch
from
ac1eee4
to
3ee3b8a
Compare
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
force-pushed
the
ewan/opencl_update_ur_bump
branch
from
3ee3b8a
to
96fce7b
Compare
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
added a commit
to Bensuo/unified-runtime
that referenced
this pull request
Feb 27, 2024
Implement the API for updating the kernel commands in a command-buffer defined by oneapi-src#1089 for the OpenCL adapter. However, the following changes to the UR kernel update API have been made based on implementation experience: 1. Forbid updating the work-dim of the kernel, see KhronosGroup/OpenCL-Docs#1057 2. Remove struct fields to update exec info, after [DPC++ implementation prototype](intel/llvm#12840) shows this isn't needed. This adapter implementation depends on support for the [cl_khr_command_buffer_mutable_dispatch](https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_Ext.html#cl_khr_command_buffer_mutable_dispatch) extension. Tested on Intel GPU/CPUs OpenCL implementations with the [command-buffer emulation layer](https://github.com/bashbaug/SimpleOpenCLSamples/tree/main/layers/10_cmdbufemu). ```bash $ OPENCL_LAYERS=<path/to/SimpleOpenCLSamples/build/layers/10_cmdbufemu/libCmdBufEmu.so> ./bin/test-exp_command_buffer --platform="Intel(R) OpenCL Graphics" ``` DPC++ PR intel/llvm#12724
EwanC
added a commit
to Bensuo/unified-runtime
that referenced
this pull request
Mar 14, 2024
Implement the API for updating the kernel commands in a command-buffer defined by oneapi-src#1089 for the OpenCL adapter. However, the following changes to the UR kernel update API have been made based on implementation experience: 1. Forbid updating the work-dim of the kernel, see KhronosGroup/OpenCL-Docs#1057 2. Remove struct fields to update exec info, after [DPC++ implementation prototype](intel/llvm#12840) shows this isn't needed. 3. Forbid changing the local work size from user to impl defined and vice-versa. See discussion in [L0 implementation PR](oneapi-src#1353 (comment)). This adapter implementation depends on support for the [cl_khr_command_buffer_mutable_dispatch](https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_Ext.html#cl_khr_command_buffer_mutable_dispatch) extension. Tested on Intel GPU/CPUs OpenCL implementations with the [command-buffer emulation layer](https://github.com/bashbaug/SimpleOpenCLSamples/tree/main/layers/10_cmdbufemu). ```bash $ OPENCL_LAYERS=<path/to/SimpleOpenCLSamples/build/layers/10_cmdbufemu/libCmdBufEmu.so> ./bin/test-exp_command_buffer --platform="Intel(R) OpenCL Graphics" ``` DPC++ PR intel/llvm#12724
EwanC
force-pushed
the
ewan/opencl_update_ur_bump
branch
from
96fce7b
to
011dfc3
Compare
EwanC
added a commit
to Bensuo/unified-runtime
that referenced
this pull request
Mar 25, 2024
Implement the API for updating the kernel commands in a command-buffer defined by oneapi-src#1089 for the OpenCL adapter. However, the following changes to the UR kernel update API have been made based on implementation experience: 1. Forbid updating the work-dim of the kernel, see KhronosGroup/OpenCL-Docs#1057 2. Remove struct fields to update exec info, after [DPC++ implementation prototype](intel/llvm#12840) shows this isn't needed. 3. Forbid changing the local work size from user to impl defined and vice-versa. See discussion in [L0 implementation PR](oneapi-src#1353 (comment)). This adapter implementation depends on support for the [cl_khr_command_buffer_mutable_dispatch](https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_Ext.html#cl_khr_command_buffer_mutable_dispatch) extension. Tested on Intel GPU/CPUs OpenCL implementations with the [command-buffer emulation layer](https://github.com/bashbaug/SimpleOpenCLSamples/tree/main/layers/10_cmdbufemu). ```bash $ OPENCL_LAYERS=<path/to/SimpleOpenCLSamples/build/layers/10_cmdbufemu/libCmdBufEmu.so> ./bin/test-exp_command_buffer --platform="Intel(R) OpenCL Graphics" ``` DPC++ PR intel/llvm#12724
EwanC
force-pushed
the
ewan/opencl_update_ur_bump
branch
from
011dfc3
to
2104f6b
Compare
EwanC
force-pushed
the
ewan/opencl_update_ur_bump
branch
from
2104f6b
to
f42df41
Compare
EwanC
force-pushed
the
ewan/opencl_update_ur_bump
branch
from
28ff63a
to
d081ff0
Compare
EwanC
force-pushed
the
ewan/opencl_update_ur_bump
branch
from
d081ff0
to
84909c0
Compare
Bensuo
approved these changes
Apr 23, 2024
kbenzie
approved these changes
Apr 23, 2024
EwanC
force-pushed
the
ewan/opencl_update_ur_bump
branch
from
84909c0
to
f6765d0
Compare
EwanC
force-pushed
the
ewan/opencl_update_ur_bump
branch
from
f6765d0
to
28c1972
Compare
EwanC
force-pushed
the
ewan/opencl_update_ur_bump
branch
from
28c1972
to
de62f57
Compare
Test the UR commit that enables updating kernel commands in a command-buffer in the OpenCL adapter.
EwanC
force-pushed
the
ewan/opencl_update_ur_bump
branch
from
c076579
to
de92ea2
Compare
|
@intel/llvm-gatekeepers please merge |
|
ping @intel/llvm-gatekeepers for merging, this UR bump also includes a Jenkins/Precommit fix that could unblock other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test the UR commit that enables updating kernel commands in a command-buffer in the OpenCL adapter oneapi-src/unified-runtime#1358