Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Doc] Add spec to get device image backend content #14811

Merged
merged 10 commits into from
Dec 3, 2024

Commits on Jul 26, 2024

  1. [SYCL][Doc] Add spec to get device image content

    Add a proposed specification for an extension that returns the content
    of a device image.
    gmlueck committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f09c9d6 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Fix typo

    gmlueck committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    2cd6478 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Constrain to "executable" bundles

    A couple changes to simplify and clarify this extension:
    
    * Rename the functions to make it clear they get the "backend" content
      of the device image.  This will avoid confusion with a new member
      function `kernel_bundle::ext_oneapi_get_content` that we plan to add
      in a separate extension.
    
    * Constrain the functions, so they are only available when the kernel
      bundle is `bundle_state::executable`.  This is the only case we need
      now, and it avoids the need to define what is returned in the other
      states.
    gmlueck committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    793b739 View commit details
    Browse the repository at this point in the history
  2. Rename file

    gmlueck committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    bf6b734 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a548105 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Apply suggestions from code review

    Co-authored-by: John Pennycook <[email protected]>
    gmlueck and Pennycook authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    5f17499 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: John Pennycook <[email protected]>
    gmlueck and Pennycook authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    ef53b68 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    acd6b94 View commit details
    Browse the repository at this point in the history
  4. Tweak wording on availability

    gmlueck committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    d288119 View commit details
    Browse the repository at this point in the history
  5. Add API to get backend and tweak lifetime of view

    Two changes that make it easier to use `device_image` by code that
    does not also have the `kernel_bundle` object:
    
    * Add an API to `device_image` that returns the backend.
    * Change the lifetime of the content view to be the lifetime of the
      `device_image` object instead of the containing `kernel_bundle` object.
    gmlueck committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    236c32e View commit details
    Browse the repository at this point in the history