Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeviceSanitizer] Support "-fsanitize-ignorelist=" to disable sanitizing on some of kernels #15294

Merged
merged 43 commits into from
Nov 27, 2024

Conversation

AllanZyne
Copy link
Contributor

@AllanZyne AllanZyne commented Sep 5, 2024

UR: oneapi-src/unified-runtime#2055

We reuse -fsanitize-ignorelist= to support kernel filtering.

Usage: https://clang.llvm.org/docs/SanitizerSpecialCaseList.html

We implement this feature by adding a device global "__AsanKernelMetadata" which records the sanitized kernel name, so that we can check if we need specially handle kernel in UR.

@AllanZyne
Copy link
Contributor Author

AllanZyne commented Nov 22, 2024

Waiting for #15843 being merged.

Copy link
Contributor

@zhaomaosu zhaomaosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllanZyne
Copy link
Contributor Author

Hi @intel/llvm-gatekeepers @intel/unified-runtime-reviewers , please merge.
Thanks!

@pbalcer
Copy link
Contributor

pbalcer commented Nov 26, 2024

Hi @intel/llvm-gatekeepers @intel/unified-runtime-reviewers , please merge. Thanks!

This is not ready to merge. The UR part isn't merged yet.

Copy link
Contributor

@callumfare callumfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UR PR was merged and the tag has been updated now

@AllanZyne
Copy link
Contributor Author

@pbalcer @callumfare, Thanks!

@pbalcer
Copy link
Contributor

pbalcer commented Nov 27, 2024

@intel/llvm-gatekeepers please merge

@martygrant martygrant merged commit 34554e6 into sycl Nov 27, 2024
13 checks passed
@AllanZyne AllanZyne deleted the review/yang/fix_kernel_filter branch November 28, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants