[SYCL] Add (raw|decorated)_generic_ptr aliases
#15389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
gmlueck
approved these changes
Sep 13, 2024
aelovikov-intel
approved these changes
Sep 13, 2024
|
This will have a minor conflict with #15402 (see FIXME in the test there). I assume we're waiting for the Khronos PR to be merged in before merging this one. |
KornevNikita
added a commit
to KornevNikita/llvm
that referenced
this pull request
Nov 5, 2024
Waiting for intel#15389. The test also needs to be updated then.
KornevNikita
added a commit
to KornevNikita/llvm
that referenced
this pull request
Nov 5, 2024
Waiting for intel#15389. The test also needs to be updated then.
steffenlarsen
pushed a commit
that referenced
this pull request
Nov 6, 2024
Waiting for #15389. The test also needs to be updated then.
KhronosGroup/SYCL-Docs#598 adds these aliases to the spec. Prepare for spec change by adding them to the implementation beforehand. Extend tests so all `multi_ptr` aliases are checked. Signed-off-by: Victor Perez <[email protected]>
victor-eds
force-pushed
the
generic-ptr-aliases
branch
from
b4a1570
to
dda54cc
Compare
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Upstream PR was merged and this can now be merged too. |
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers can we get this merged? |
|
@victor-eds hi! Do you plan to update SYCL-CTS to turn it on on DPCPP? If so, could you please share a link to PR then? |
Yes! I have that in my backlog 😄 |
|
sarnex
pushed a commit
that referenced
this pull request
Dec 2, 2024
After #15389 and KhronosGroup/SYCL-CTS#935 got merged, these CTS tests can be reenabled. Signed-off-by: Victor Perez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KhronosGroup/SYCL-Docs#598 adds these aliases to the spec. Prepare for spec change by adding them to the implementation beforehand.
Extend tests so all
multi_ptraliases are checked.