Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Graph] Adding new graph enqueue function to spec #15677

Merged
merged 20 commits into from
Nov 6, 2024
Merged

[SYCL][Graph] Adding new graph enqueue function to spec #15677

merged 20 commits into from
Nov 6, 2024

Conversation

reble
Copy link
Contributor

@reble reble commented Oct 11, 2024

replacing #15385 after offline discussion.

@reble reble marked this pull request as ready for review October 22, 2024 19:39
@reble reble requested review from a team as code owners October 22, 2024 19:39
aelovikov-intel
aelovikov-intel reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we anticipate the need to pass any compile-time properties to these methods in future?

@EwanC
Copy link
Contributor

EwanC commented Oct 23, 2024

Do we anticipate the need to pass any compile-time properties to these methods in future?

This PR modifies the submit/submit_with_event entry-point to add variants with the extra properties parameters #15704, I think we should be consistent with that and have a way to pass properties.

gmlueck
gmlueck approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec changes LGTM.

@reble
Copy link
Contributor Author

reble commented Nov 6, 2024

Do we anticipate the need to pass any compile-time properties to these methods in future?

This PR modifies the submit/submit_with_event entry-point to add variants with the extra properties parameters #15704, I think we should be consistent with that and have a way to pass properties.

Graph related functions have been renamed, and there has been a consensus that those variants with extra property parameters are not required for the new functions.

@reble
Copy link
Contributor Author

reble commented Nov 6, 2024

@intel/llvm-gatekeepers This PR can be merged. Thanks!

@sarnex
Copy link
Contributor

sarnex commented Nov 6, 2024

This needs a review from @intel/llvm-reviewers-runtime

@aelovikov-intel aelovikov-intel merged commit 66867d4 into intel:sycl Nov 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwanC EwanC EwanC approved these changes

@Pennycook Pennycook Pennycook left review comments

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@gmlueck gmlueck gmlueck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@reble @EwanC @sarnex @Pennycook @gmlueck @aelovikov-intel