Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Add support for work group memory free function kernel parameter #15861

Merged
merged 138 commits into from
Nov 19, 2024
Merged

[SYCL] Add support for work group memory free function kernel parameter #15861

merged 138 commits into from
Nov 19, 2024

Conversation

lbushi25
Copy link
Contributor

@lbushi25 lbushi25 commented Oct 24, 2024 •
edited
Loading

This PR concludes the implementation of the work group memory extension.
It adds support for work group memory parameters when using free function kernels.

lbushi25 and others added 30 commits August 14, 2024 15:16
@lbushi25
Preliminary implementation of work_group_memory extension
652caa8
@lbushi25
Preliminary implementation of work_group_memory extension
76daf77
@lbushi25
Implement work_group_memory extension
21e082b
@lbushi25
Implement work_group_memory extension
025cbc4
@lbushi25
Implement work group memory
b94f7c9
@lbushi25
Remove debug dumps
0d6d694
@lbushi25
Merge branch 'intel:sycl' into work_group_memoy_new
448071f
@lbushi25
Update work_group_memory.hpp
9f2973a
@lbushi25
Remove include of deleted header file
852315f
@lbushi25
Fix SPIRV compilation errors
4234022
@lbushi25
Remove accidental change
ae5eb7e
@lbushi25
Formatting changes
8ce0280
@lbushi25
Formatting changes
4ee31a5
@lbushi25
Put the work group memory doc to supported
7b1b90b
@lbushi25
More formatting changes
cf7476e
@lbushi25
Delete sycl/include/sycl/ext/oneapi/experimental/test.cpp
50c0954
@lbushi25
Yet more formatting changes
44811b8
@lbushi25
Merge branch 'work_group_memoy_new' of https://github.com/lbushi25/llvm…
ad1046f 
… into work_group_memoy_new
@lbushi25
Fix warnings on Linux
d343a2e
@lbushi25
Remove unnecessary forward declaration from handler.hpp
3f1bc30
@lbushi25
Remove rvalue references in favor of const lvalue references
103e233
@lbushi25
Fix syntax errors
bfa5830
@lbushi25
Fix syntax errors
2031478
@lbushi25
Don't explicitly make the work_group_memory class device-copyable as …
76f0acc 
…it already is
@lbushi25
Don't explicitly make the work_group_memory class device-copyable as …
e0ad435 
…it already is
@lbushi25
Remove some more unnecessary code
3513251
@lbushi25
Update work_group_memory.hpp
2cec997
@lbushi25
Update work_group_memory.hpp
4c8b196
@lbushi25
Formatting
a0b70e2
@lbushi25
Move doc to experimental folder
ed8f125
@lbushi25 lbushi25 requested a review from gmlueck November 19, 2024 14:38
steffenlarsen
steffenlarsen approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbushi25
Copy link
Contributor Author

lbushi25 commented Nov 19, 2024 •
edited
Loading

Waiting for #16119 to resolve pre-commit failures. Also removed free_function_kernel.cpp in favor of reduction_free_function.cpp which was added in another PR. The latter is a more exhaustive test.

@lbushi25
Copy link
Contributor Author

@intel/llvm-gatekeepers This is ready for merge.

@sarnex sarnex merged commit 39483ab into intel:sycl Nov 19, 2024
13 checks passed
@sommerlukas sommerlukas mentioned this pull request Feb 4, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pennycook Pennycook Pennycook left review comments

@tahonermann tahonermann tahonermann left review comments

@premanandrao premanandrao premanandrao left review comments

@elizabethandrews elizabethandrews elizabethandrews approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov sergey-semenov is a code owner automatically assigned from intel/llvm-reviewers-runtime

@gmlueck gmlueck Awaiting requested review from gmlueck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lbushi25 @Pennycook @tahonermann @gmlueck @premanandrao @elizabethandrews @steffenlarsen @sarnex