Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][E2E] Update get_coordinate tests to verify both row and columns #15880

Draft
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Draft

[SYCL][E2E] Update get_coordinate tests to verify both row and columns #15880

wants to merge 1 commit into from

Conversation

YixingZhang007
Copy link
Contributor

@YixingZhang007 YixingZhang007 commented Oct 26, 2024 •
edited
Loading

Improving Test Coverage and Cleanliness:

  • Implement validation for the get_coordinate function to check both row and column indices for all matrix types in get_coordinate_ops.cpp.
  • Remove the original tests: get_coord_int8_matA.cpp, get_coord_int8_matB.cpp, and get_coord_float_matC.cpp. These tests have been consolidated and are now included in get_coordinate_ops.cpp.

@YixingZhang007 YixingZhang007 requested a review from a team as a code owner October 26, 2024 00:02
@YixingZhang007 YixingZhang007 marked this pull request as draft October 26, 2024 00:02
@YixingZhang007 YixingZhang007 self-assigned this Oct 26, 2024
@YixingZhang007 YixingZhang007 changed the title Update get_coordinate tests to verify both row and columns for all matrix types Update get_coordinate tests to verify both row and columns Oct 26, 2024
@YixingZhang007 YixingZhang007 changed the title Update get_coordinate tests to verify both row and columns [SYCL][E2E] Update get_coordinate tests to verify both row and columns Oct 26, 2024
@YixingZhang007
Copy link
Contributor Author

This PR is still in progress. There might be some code clean up needed to be done.

@uditagarwal97
Copy link
Contributor

@YixingZhang007 I've updated the PR description to remove the JIRA link. The policy does not allow using internal JIRA links in open-source, only JIRA ticket numbers are allowed.

dkhaldi
dkhaldi reviewed Nov 5, 2024
View reviewed changes
sycl/test-e2e/Matrix/get_coordinate_ops_impl.hpp
test_get_coord_op<int8_t, int32_t, /*TK*/ 32, /*TN*/ 16, use::b,
layout::ext_intel_packed, 4>();
test_get_coord_op<float, float, /*TM*/ 8, /*TN*/ 16, use::accumulator,
layout::row_major, 1>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, please add the extra cases to DG2 and AMX as well:

  • a row major bfloat16
  • b row major bfloat16
  • b packed bfloat16
  • b row major int8
  • c int32 row major

Also, I see that - b row major int8 is missing in PVC. Please add that as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I have included each of the following cases for DG2, AMX and PVC.

  • a row_major bloat16
  • a row_major int8
  • b row_major bloat16
  • b row_major int8
  • b packed bloat16
  • b packed int8
  • a float
  • a int32

Please feel free to let me know if there is any other cases need to be added :)

dkhaldi
dkhaldi approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhaldi dkhaldi dkhaldi approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@YixingZhang007 YixingZhang007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YixingZhang007 @uditagarwal97 @dkhaldi