[SYCL] fix post-commit failures from kernel_compiler sycl cache PR #15968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…piler is not available. Previously, the test just quietly exited, but for the cache support the test grew a bit. Now we check the availability before proceeding
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
approved these changes
Nov 1, 2024
maarquitos14
approved these changes
Nov 4, 2024
jopperm
reviewed
Nov 12, 2024
Comment on lines
+19
to
+21
| // DEFINE: %{available} = %t.out available | ||
|
|
||
| // RUN: %if available %{ %{run} %t.out %} |
There was a problem hiding this comment.
I think this condition doesn't work as expected. Regardless of whether the executable returns 0 or 1, I get
# RUN: at line 21 has no command after substitutions
Can such a substitution be used for the %if construct? The testing guide only mention "features" as conditions.
There was a problem hiding this comment.
I think you are right - these tests aren't running at all. This is a problem, the post-commit testing has a pass where the invoking kernel_compiler simply isn't available. Might have to figure out a different way of excluding that pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in some of the post commit testing the SYCL support of the kernel_compiler is not available. Previously, the test just quietly exited, but for the cache support the test grew a bit. Now we check the availability before proceeding.
Post commit checks for this are presently running here: https://github.com/intel/llvm/actions/runs/11636755314/job/32408707610