Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test for queue::fill with a range of pattern sizes #15991

Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

Add e2e test for queue::fill with a range of pattern sizes #15991

wants to merge 3 commits into from

Commits on Nov 22, 2024

  1. [UR][CUDA][HIP] Fix incorrect outputs and improve performance of queu… 

    …e::fill

Update the UR tag to fix queue::fill for the CUDA and HIP backends, which was
previously producing incorrect outputs for any pattern size other than 1, 2,
or a multiple of 4 bytes. A new optimisation is also added which speeds up
the fill greatly if the pattern equals to the first word repeated throughout
(e.g. all zeros).

Add a new e2e test to validate queue::fill outputs for any pattern size
between 1 and 32 bytes. This test fails for CUDA and HIP before the UR change
and passes with this PR. Other backends already worked correctly.
    @rafbiels
    rafbiels committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    6c75eb1 View commit details
    Browse the repository at this point in the history

  2. Apply review suggestions

    @rafbiels
    rafbiels committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    dbe6aa5 View commit details
    Browse the repository at this point in the history

  3. Update printf format following variable type change to size_t

    @rafbiels
    rafbiels committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    e86712f View commit details
    Browse the repository at this point in the history