[SYCL][Graph] Fix CUDA/HIP local mem argument update bug #16025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
force-pushed
the
ewan/cuda_local_mem_fix
branch
from
5b0b1d0
to
731cdc0
Compare
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
changed the title
EwanC
force-pushed
the
ewan/cuda_local_mem_fix
branch
from
731cdc0
to
c30fc25
Compare
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
force-pushed
the
ewan/cuda_local_mem_fix
branch
from
c30fc25
to
2771f66
Compare
EwanC
force-pushed
the
ewan/cuda_local_mem_fix
branch
from
2771f66
to
8429c05
Compare
EwanC
force-pushed
the
ewan/cuda_local_mem_fix
branch
from
8429c05
to
a5f439c
Compare
EwanC
force-pushed
the
ewan/cuda_local_mem_fix
branch
from
a5f439c
to
598e0a9
Compare
EwanC
force-pushed
the
ewan/cuda_local_mem_fix
branch
from
598e0a9
to
9ce1cc4
Compare
Tests UR PR oneapi-src/unified-runtime#2298 with additional SYCL-Graph local memory argument E2E tests. PR also sets the `pnext` and `snext` members of `ur_exp_command_buffer_update_kernel_launch_desc_t ` which were missing when calling into UR.
EwanC
force-pushed
the
ewan/cuda_local_mem_fix
branch
from
9ce1cc4
to
b6e03ad
Compare
aelovikov-intel
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Not related to the changes but why does this test have
using T = inton line 9?
There was a problem hiding this comment.
Okay, I can see the other tests also use that. I guess it's convenient
There was a problem hiding this comment.
Good question, it's in a lot of our tests. The idea we that it makes it easier to test with different input/output types if we want. However, I don't think that hypothetical advantage has ever been taken advantage of.
Thinking about it, it might make more sense to put this in the graph_common.hpp header and let individual tests use it if they want.
Bensuo
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests UR PR oneapi-src/unified-runtime#2298 with additional SYCL-Graph local memory argument E2E tests.
PR also sets the
pnextandsnextmembers ofur_exp_command_buffer_update_kernel_launch_desc_twhich were missing when calling into UR.