Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Bindless][E2E] fix double free in vulkan interop unsampled test #16027

Open
wants to merge 6 commits into
base: sycl
Choose a base branch
from
Open

[SYCL][Bindless][E2E] fix double free in vulkan interop unsampled test #16027

wants to merge 6 commits into from

Conversation

cppchedy
Copy link
Contributor

@cppchedy cppchedy commented Nov 8, 2024

  • fix double free in vulkan interop unsampled test

@cppchedy
Copy link
Contributor Author

UR PR

@cppchedy cppchedy marked this pull request as ready for review November 13, 2024 14:45
@cppchedy cppchedy requested review from a team as code owners November 13, 2024 14:45
DBDuncan
DBDuncan reviewed Nov 13, 2024
View reviewed changes
sycl/cmake/modules/FetchUnifiedRuntime.cmake Outdated
@@ -117,7 +117,7 @@ if(SYCL_UR_USE_FETCH_CONTENT)
endfunction()

set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules/UnifiedRuntimeTag.cmake)
set(UNIFIED_RUNTIME_TAG 698cd9974c18874bf6a7e9ec78507c30b9deeca7)
Copy link
Contributor

@DBDuncan DBDuncan Nov 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe now you need to instead edit UnifiedRuntimeTag.cmake with the new commit and leave this line unedited.

Copy link
Contributor Author

@cppchedy cppchedy Nov 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah. thank you. I missed this change. fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DBDuncan DBDuncan DBDuncan approved these changes

@przemektmalon przemektmalon przemektmalon approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cppchedy @przemektmalon @DBDuncan