Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Make core.hpp independent from sub_group.hpp #16044

Merged

Conversation

AlexeySachkov
Copy link
Contributor

This PR will also allow us to remove sub_group.hpp from sycl.hpp to make the former an opt-in header (for better compile-times).

This PR will also allow us to remove `sub_group.hpp` from `sycl.hpp` to
make the former an opt-in header (for better compile-times).
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graph test LGTM

Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test change lgtm

@againull againull merged commit b1f4cf7 into intel:sycl Nov 12, 2024
16 checks passed
@AlexeySachkov AlexeySachkov deleted the private/asachkov/dont-include-sub-group-hpp branch November 12, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants