Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E][SYCL] Test for empty command group behavior #16166

Merged
merged 4 commits into from
Nov 25, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 112 additions & 0 deletions sycl/test-e2e/Basic/empty_command.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
// RUN: %{build} -o %t.out %cxx_std_optionc++20
// RUN: %{run} %t.out

#include <sycl/detail/core.hpp>
#include <sycl/usm.hpp>

#include <latch>
#include <thread>

using namespace sycl;

void test_host_task_dep() {
queue q;

std::latch start_execution{1};

int x = 0;

auto host_event = q.submit([&](handler &cgh) {
cgh.host_task([&]() {
start_execution.wait();
x = 42;
});
});

auto empty_cg_event =
q.submit([&](handler &cgh) { cgh.depends_on(host_event); });

// FIXME: This should deadlock, but the dependency is ignored currently.
empty_cg_event.wait();

assert(x == 0);
start_execution.count_down();

empty_cg_event.wait();
// FIXME: uncomment once the bug mentioned above is fixed.
// assert(x == 42);

// I'm seeing some weird hang without this:
host_event.wait();
}

void test_device_event_dep() {
queue q;

std::latch start_execution{1};
auto *p = sycl::malloc_shared<int>(1, q);
*p = 0;

auto host_event = q.submit(
[&](handler &cgh) { cgh.host_task([&]() { start_execution.wait(); }); });
auto device_event = q.single_task(host_event, [=]() { *p = 42; });
auto empty_cg_event =
q.submit([&](handler &cgh) { cgh.depends_on(device_event); });

// FIXME: This should deadlock, but the dependency is ignored currently.
empty_cg_event.wait();

assert(*p == 0);
start_execution.count_down();

empty_cg_event.wait();
// FIXME: uncomment once the bug mentioned above is fixed.
// assert(*p == 42);

q.wait();
sycl::free(p, q);
}

void test_accessor_dep() {
queue q;

std::latch start_execution{1};
auto *p = sycl::malloc_shared<int>(1, q);
*p = 0;

auto host_event = q.submit(
[&](handler &cgh) { cgh.host_task([&]() { start_execution.wait(); }); });

sycl::buffer<int, 1> b{1};
auto device_event = q.submit([&](auto &cgh) {
cgh.depends_on(host_event);
sycl::accessor a{b, cgh};

cgh.single_task([=]() {
*p = 42;
a[0] = 42;
});
});
auto empty_cg_event =
q.submit([&](handler &cgh) { sycl::accessor a{b, cgh}; });

// FIXME: This should deadlock, but the dependency is ignored currently.
empty_cg_event.wait();

assert(*p == 0);
start_execution.count_down();

empty_cg_event.wait();
// FIXME: uncomment once the bug mentioned above is fixed.
// assert(*p == 42);
maarquitos14 marked this conversation as resolved.
Show resolved Hide resolved

q.wait();
sycl::free(p, q);
}

int main() {
test_host_task_dep();
test_device_event_dep();
test_accessor_dep();
return 0;
}
Loading