[LIBCLC] Modify libclc-remangler cmds for cross-compile support #16182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because libclc-remangler commands executed in cmake use `libclc::libclc-remangler`, builds where `CMAKE_CROSSCOMPILING=ON` do not work correctly since cmake assumes the target is not executable on the host machine. This change modifies the custom commands to use the cache variable `LIBCLC_REMANGLER_PATH` instead, where this variable is set in a similar way as llvm tools such as `llvm-config` by calling `compile_native_tool`. Signed-off-by: Jack Myers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because libclc-remangler commands executed in cmake use
libclc::libclc-remangler, builds whereCMAKE_CROSSCOMPILING=ONdo not work correctly since cmake assumes the target is not executable on the host machine.This change modifies the custom commands to use the cache variable
LIBCLC_REMANGLER_PATHinstead, where this variable is set in a similar way as llvm tools such asllvm-configby callingcompile_native_tool.