[SYCL][Graph][L0] Enable Copy engine support with in-order command lists #16830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
reble
changed the title
EwanC
reviewed
Jan 31, 2025
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
konradkusiak97
force-pushed
the
URaddInOrderCopyEngineSupport
branch
from
f47bd58 to
c043121
Compare
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
konradkusiak97
force-pushed
the
URaddInOrderCopyEngineSupport
branch
from
c043121 to
e99190c
Compare
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
reviewed
Feb 13, 2025
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
konradkusiak97
force-pushed
the
URaddInOrderCopyEngineSupport
branch
from
6f361e3 to
b8606ee
Compare
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
konradkusiak97
force-pushed
the
URaddInOrderCopyEngineSupport
branch
from
b8606ee to
8af054f
Compare
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
konradkusiak97
changed the title
konradkusiak97
force-pushed
the
URaddInOrderCopyEngineSupport
branch
from
8af054f to
b7fad63
Compare
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
konradkusiak97
force-pushed
the
URaddInOrderCopyEngineSupport
branch
from
99963be to
8edf64f
Compare
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
approved these changes
Mar 3, 2025
|
CUDA failure is unrelated. This is ready to go, @intel/llvm-gatekeepers, could you merge this please? |
|
Failed Tests (1): Known issue: #17026 |
sommerlukas
pushed a commit
that referenced
this pull request
Mar 11, 2025
Following #16830, this PR adds an additional e2e graph test to invoke copy engine on L0 devices and test its behaviour.
adamfidel
pushed a commit
to reble/llvm
that referenced
this pull request
Mar 11, 2025
…l#17324) Following intel#16830, this PR adds an additional e2e graph test to invoke copy engine on L0 devices and test its behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, copy engine is only available to use for certain commands in the out-of-order command-buffer path. This PR adds required synchronization between the 2 command lists, when both are in-order. Hence, it enables using the copy engine with in-order path.
For the immediateAppend path, this only works for now if the environment variable
UR_L0_USE_DRIVER_COUNTER_BASED_EVENTS=0is set.