[CI] Fix workflow to check use of private emails #17333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
|
I think the reason why this workflow didn't get triggered on #17065 is because we were missing the synchronize event type in this workflow. So, using the defaults pull_request trigger type (open, re-open, sync) should fix it. |
|
But, here's a downside to this change: The workflow will issue multiple comments (if the user is not using intel/codeplay email), every time a pull-request is re-opened or synchronized. I personally think it's not that big of an issue as it won't affect most contributors of intel/llvm |
sarnex
approved these changes
Mar 6, 2025
|
Canceling pre-commit CI and merging - this change shouldn't affect SYCL Build or testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request
By adding
types: - opened, we are restricting this workflow to run only when the PR is first opened. I don't see a good reason to do that. This PR removed it and also makes sure that this workflow is triggered only on certain branches.