Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][ESIMD][E2E] Re-enable atomic update SLM tests on DG2 #17716

Closed
wants to merge 1 commit into from
Closed

[SYCL][ESIMD][E2E] Re-enable atomic update SLM tests on DG2 #17716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions sycl/test-e2e/ESIMD/unified_memory_api/Inputs/atomic_update_slm.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,11 +588,8 @@ template <int N, template <class, int> class Op, bool UseMask,
bool test_fp_types(queue &q) {
bool passed = true;

// TODO: Enable 'half' FADD/FSUB on DG2 when the error in GPU driver is fixed.
if constexpr (Features == TestFeatures::PVC ||
(Features == TestFeatures::DG2 &&
!std::is_same_v<Op<sycl::half, N>, ImplFadd<sycl::half, N>> &&
!std::is_same_v<Op<sycl::half, N>, ImplFsub<sycl::half, N>>)) {
Features == TestFeatures::DG2) {
if (q.get_device().has(sycl::aspect::fp16)) {
passed &= run_test<UseAcc, sycl::half, N, Op, UseMask>(q);
}
Expand Down Expand Up @@ -691,9 +688,8 @@ int test_with_mask(queue &q) {
passed &=
test_fp_types_and_sizes<ImplLSCFmin, UseMask, Features, UseAcc>(q);
}
// TODO: GPU driver promised to support FADD/FSUB on DG2, but it doesn't.
// Report the issue to driver, enable FADD/FSUB for DG2 when it is fixed.
if constexpr (Features == TestFeatures::PVC) {
if constexpr (Features == TestFeatures::DG2 ||
Features == TestFeatures::PVC) {
passed &= test_fp_types_and_sizes<ImplFadd, UseMask, Features, UseAcc>(q);
passed &= test_fp_types_and_sizes<ImplFsub, UseMask, Features, UseAcc>(q);
}
Expand Down
Loading