[CI] Don't try to run detect changes for large PR #17728
Conversation
https://github.com/intel/llvm/actions/runs/14151976801/job/39646329170?pr=17710 The step will crash if the change files are huge.
|
It "worked" (as in not crashing) for every pulldown before, what has changed? |
|
Yeah we already have the same check below, so I'm not sure what changed or how this addresses the problem we're seeing |
Looks like the latest pulldown is much larger than before, so it is crashing. |
The fix will skip the step that is crashing (line 31 is the most interested line), hopefully, we can bypass the crash. (I can't verifiy as pushing to to pulldown branch did not take effect). |
| @@ -81,8 +91,6 @@ jobs: | |||
| uses: actions/github-script@v7 | |||
| with: | |||
| script: | | |||
| console.log("Number of files changed:"); | |||
| console.log(context.payload.pull_request.changed_files); | |||
| if (context.payload.pull_request.changed_files < 500) { | |||
There was a problem hiding this comment.
if we moved the if to the job level can we remove it here?
There was a problem hiding this comment.
We still need this to choose the outputs, unless we set the default output in 1st step too.
| - name: Check file changes | ||
| uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 | ||
| if: ${{ steps.changed_files.outputs.changed_files }} < 500 |
There was a problem hiding this comment.
| if: ${{ steps.changed_files.outputs.changed_files }} < 500 | |
| if: ${{ context.payload.pull_request.changed_files }} < 500 |
to have the same condition here and on line 94 (and it's just a few characters difference, so not important). Once done, previous step can be changed/renamed to simply logging-related.
There was a problem hiding this comment.
https://github.com/intel/llvm/actions/runs/14176543100 context is not available here.
|
@intel/llvm-gatekeepers Can someone help to merge this? Thanks. |
https://github.com/intel/llvm/actions/runs/14151976801/job/39646329170?pr=17710 The step will crash if the change files are huge.
https://github.com/intel/llvm/actions/runs/14151976801/job/39646329170?pr=17710
The step will crash if the change files are huge.