Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Benchmark] Merge "add UMF benchmarks for fragmentation measurements" into sycl #17729

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

ianayl
Copy link
Contributor

@ianayl ianayl commented Mar 31, 2025

Land #17608 into sycl branch as well

Original PR was by @EuphoricThinking, here is her original PR description:

Beside the new class for fragmentation measurements, ComputeUMFBenchmark base class is directly replaced by GBench. Methods and attributes previously included in ComputeUMFBenchmark have been relevant only for Google Benchmark, therefore inheriting from ComputeUMFBenchmark would have been pointless for benchmarks using other frameworks.

Additionally, each benchmark is run separately in order to avoid any impact of benchmarks on each other. Benchmarks using glibc are excluded from fragmentation measurements.

…7608)

Beside the new class for fragmentation measurements, ComputeUMFBenchmark
base class is directly replaced by GBench. Methods and attributes
previously included in ComputeUMFBenchmark have been relevant only for
Google Benchmark, therefore inheriting from ComputeUMFBenchmark would
have been pointless for benchmarks using other frameworks.

Additionally, each benchmark is run separately in order to avoid any
impact of benchmarks on each other. Benchmarks using glibc are excluded
from fragmentation measurements.
@ianayl ianayl temporarily deployed to WindowsCILock March 31, 2025 02:46 — with GitHub Actions Inactive
@ianayl ianayl changed the title [CI][Benchmark] Merge "add UMF benchmarks for fragmentation measurements [CI][Benchmark] Merge "add UMF benchmarks for fragmentation measurements" into sycl Mar 31, 2025
@ianayl ianayl temporarily deployed to WindowsCILock March 31, 2025 02:56 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock March 31, 2025 02:56 — with GitHub Actions Inactive
@ianayl ianayl marked this pull request as ready for review April 1, 2025 03:45
@ianayl ianayl requested a review from a team as a code owner April 1, 2025 03:45
@ianayl ianayl temporarily deployed to WindowsCILock April 1, 2025 03:48 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock April 1, 2025 03:58 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock April 1, 2025 03:58 — with GitHub Actions Inactive
@pbalcer
Copy link
Contributor

pbalcer commented Apr 1, 2025

@intel/llvm-gatekeepers please merge

@aelovikov-intel aelovikov-intel merged commit 49af254 into sycl Apr 1, 2025
24 checks passed
@bader bader deleted the benchmark-scripts-umf-changes branch April 3, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants