This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
migrate PR [LLM Runtime]Magicoder graph #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: intellinjun <[email protected]>
Signed-off-by: intellinjun <[email protected]>
Signed-off-by: intellinjun <[email protected]>
| @@ -178,6 +181,11 @@ def loadHFTransformerJson(model: 'LazyModel', config_path: Path) -> 'Params': | |||
| ffn_hidden_size = config["intermediate_size"] | |||
| rms_norm_eps = config["rms_norm_eps"] | |||
| rope_theta = config["rope_theta"] if "rope_theta" in config else 10000 | |||
| rope_scale = 1 | |||
| if config["rope_scaling"]: | |||
There was a problem hiding this comment.
please check whether "rope_scaling" in config
Suggested change
| if config["rope_scaling"]: | |
| if "rope_scaling" in config and config["rope_scaling"] is not None: |
| @@ -179,6 +180,8 @@ def loadHFTransformerJson(model: 'LazyModel', config_path: Path) -> 'Params': | |||
| ffn_hidden_size = config["intermediate_size"] | |||
| rms_norm_eps = config["rms_norm_eps"] | |||
| rope_theta = config["rope_theta"] if "rope_theta" in config else 10000 | |||
| rope_scale = config["factor"] if "factor" in config else 1 | |||
There was a problem hiding this comment.
mistral should align to llama
There was a problem hiding this comment.
please help update convert convert_quantized_llama.py and convert_quantized_mistral.py
Signed-off-by: intellinjun <[email protected]>
Signed-off-by: intellinjun <[email protected]>
zhenwei-intel
approved these changes
Jan 10, 2024
Signed-off-by: intellinjun <[email protected]>
Signed-off-by: intellinjun <[email protected]>
Signed-off-by: intellinjun <[email protected]>
Signed-off-by: intellinjun <[email protected]>
VincyZhang
reviewed
Jan 16, 2024
Comment on lines
249
to
+250
| quant_script="./build/bin/quant_llama" | ||
| convert_script="${convert_script}/convert_bmagicoder.py" | ||
| convert_script="${convert_script}/convert_llama.py" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
feature or bug fix or documentation or others
API changed or not
Description
detail description
Issues: xxx
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed