require c++17 #941
Open
require c++17 #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I76019f2583601b0ada7808d3bb2be059584f1b0c
There was a problem hiding this comment.
Pull Request Overview
This PR updates the code to require C++17 by replacing deprecated std::bind1st calls with std::bind using std::placeholders, modernizing the whitespace trimming in the HTTPHeader class.
- Updated the leading and trailing whitespace removal logic in HTTPHeader::splitHeaderValue.
- Enhances compliance with C++17 standards.
Files not reviewed (1)
- CMakeLists.txt: Language not supported
|
I created a pull request which uses a lambda instead of using std::bind and this also works with g++ 7.5.0. Not sure where c++17 support starts though. Is there a particular reason for wanting c++17 support? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.