Updated examples and fixes #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surax98
changed the title
…o the generation of a kubeconfig
…s to be more parametric. Minors here and there
dciangot
reviewed
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Kubeconfig wasn't correctly mounted in the kubernetes deployment and the Ping function tried to create a clientset. Now They should be fixed.
The kubeconfig is not generated and sent anymore if the KUBECONFIG env is set on the InterLink host
ConfigMaps/Secrets retrieving now re-works and every file related to a specific job (for the Slurm plugin) is now stored in the same subdirectory in the form of .local/interlink/jobs/namespace-podUID (this includes JobID, job.sh, output and every configmap/secret retrieved from the pod).
Also, now InterLink queries sidecars for running/pending pods only. If the VK asks the status for succeeded/terminated pods, InterLink will provide a cached status
Related issue :
#130 #25 #90 #134