Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for improving the docs #221

Merged
merged 24 commits into from
May 23, 2024
Merged

Conversation

landerlini
Copy link

Summary

I collected in this PR some possible fixes to the docs.

The only non-editorial correction is replacing here and there the word "sidecar" with "plugin" or "container plugin".
In most implementations of interlink plugin, the plugin is not a sidecar container as it is intended in Kubernetes and this is generating confusion.

@dciangot dciangot self-requested a review May 20, 2024 14:13
Copy link
Collaborator

@dciangot dciangot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one minor comment on the IDE specific file committed

.idea/interLink.iml Show resolved Hide resolved
@dciangot dciangot self-requested a review May 23, 2024 06:47
Copy link
Collaborator

@dciangot dciangot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dciangot dciangot merged commit f0bc90b into interTwin-eu:main May 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants