Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #372 added flag DisableProjectedVolumes + fix timeout loop creation #374

Conversation

antoinetran
Copy link
Contributor

@antoinetran antoinetran commented Feb 4, 2025

Summary

Added a flag DisableProjectedVolumes in VK, set to false by default (GO default bool is false). See Helm Charts default values is also false. Also fixed the infinite timeloop of waiting volume prerequisite (configmap secret) instead of expected 5m.


Related Pull Request:
interTwin-eu/interlink-helm-chart#13
interTwin-eu/interlink-slurm-plugin#53

Related issue :
#372

@dciangot dciangot self-requested a review February 4, 2025 18:28
Copy link
Collaborator

@dciangot dciangot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pushing this through, although updated slurm plugin version might brake the ci. I'm opening a dedicated issue for that #375

@dciangot dciangot merged commit 282fe60 into interTwin-eu:main Feb 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants