Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidated Item Removal process which can be used on offshoot pages. #417

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nsharma123
Copy link
Contributor

Copy link

github-actions bot commented Jan 16, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://internetarchive.github.io/iaux-collection-browser/pr/pr-417/

Built to branch gh-pages at 2025-01-17 10:08 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@nsharma123 nsharma123 changed the title Consolidated Item Removal process for new offshoot pages. Consolidated Item Removal process which can be used on offshoot pages. Jan 16, 2025
src/collection-browser.ts Outdated Show resolved Hide resolved
src/models.ts Show resolved Hide resolved
src/manage/manage-bar.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@latonv latonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

/**
* Message shows as note in the modal when removing items
*/
@property({ type: String }) manageViewModelMsg?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting a possible small typo: Model -> Modal ?

@@ -3,7 +3,7 @@
"description": "The Internet Archive Collection Browser.",
"license": "AGPL-3.0-only",
"author": "Internet Archive",
"version": "2.7.6",
"version": "2.7.6-alpha4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder not to merge the alpha version into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants