link olid macro #9348
link olid macro #9348
Conversation
openlibrary/macros/OLID.html
Outdated
| $def with (q="#") | ||
|
|
||
| $ edition = query_param('edition', q) | ||
| $ results = find_matches(olid, q) |
There was a problem hiding this comment.
find_matches isn't a public function that's available here. It either needs to be passed in as a parameter, made a @public function, or be added to plugins/openlibrary/code.py as a template global: https://github.com/internetarchive/openlibrary/blob/master/openlibrary/plugins/openlibrary/code.py#L1146-L1171
I think though that find_matches is probably just the wrong function to use. We likely want to use some existing global function to do a web.ctx.site.things get for the specific olid (open library id)
mekarpeles
added
the
Needs: Submitter Input
|
@psyren99 please see code review comments, see if you can find a |
github-actions
bot
removed
the
Needs: Submitter Input
for more information, see https://pre-commit.ci
…y into 2283/linking_to_olid
for more information, see https://pre-commit.ci
|
Is this still open? |
|
I believe this may need a rebase, then we can throw on testing and if it works, merge :) |
|
@mekarpeles merge conflicts resolved. |
RayBB
added
the
Needs: Staff / Internal
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
openlibrary/macros/OLID.html
Outdated
| $if(olid == q): | ||
| <a href="$edition.key">$title</a> | ||
| <h6>$edition.get_authors()</h6> | ||
| <img src="/books/add?work=$edition.key" /> |
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
openlibrary/macros/OLID.html
Outdated
| $else: | ||
| <a href="$result">$olid</a> | ||
| <h6>$edition.get_authors()</h6> | ||
| <img src="/books/add?work=$olid" /> |
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
psyren99
force-pushed
the
2283/linking_to_olid
branch
2 times, most recently
from
675f256 to
729729b
Compare
for more information, see https://pre-commit.ci
|
@psyren99 looks like the linter is getting an error related to infogami. Can you try to merge the latest master branch into your branch and push that up? I think that should fix it. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
psyren99
force-pushed
the
2283/linking_to_olid
branch
from
4db6c98 to
21ab22b
Compare
Closes #2283
Create a macro for linking to an OLID
Technical
/macros/OLID.html added
/plugins/upstream/models.py
Testing
/plugins/upstream/tests/test_models.py
Screenshot
Stakeholders