Skip to content

Commit

Permalink
Merge pull request #885 from intershop/release/develop/common
Browse files Browse the repository at this point in the history
Release icm:patch icm-as:patch
  • Loading branch information
khauser authored Jan 10, 2025
2 parents 7812937 + 73f70d9 commit a34c6ee
Show file tree
Hide file tree
Showing 14 changed files with 169 additions and 73 deletions.
14 changes: 10 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,18 @@ If you have any questions feel free to also send them to this email address.
## Contribution process

1. Fork the repository
2. Use the `main` branch for your edits
2. Use the appropriate `develop\?` branch as base for your feature branch. See [Release Process](https://github.com/intershop/helm-charts/wiki/Release-Process)
3. Work on changes
4. Comment the changes
5. Check whether the changes comply with the the rules (design etc.)
6. Create a pull request
6. Commit changes according to our Commit Message Guidelines
6. Create a pull request into the `develop\?` base branch
7. Add as much information as needed
8. Reference the solved issue
9. Wait for the review
10. PR is approved, denied (with explanation) or sent back for further information
11. We are trying to react as fast as possible to pull-request, issues, feedback and any other community interaction. However, we can’t guarantee a particular timeframe for every answer. We hope you understand and apologize for any inconveniences.
12. If PR is approved the changes shall be merged via squash commit to improve commit history readability

## Commit Message Guidelines

Expand All @@ -48,6 +50,10 @@ Some rules to be emphasized for chart related commits:
* A commit message starting with `feat(icm):` (or e.g.: `feat(pwa):`) will get a _MINOR_ change.
* The rest will be _PATCH_.

Chart unreleated commits (like e.g. docs, chore, build, test) will not be taken into account but still should be conventional and informative as possible.
Please also enhance your commit message with an existing **github issue number**, where detailed information could be found. Github will later on link the commit to the issue ticket automatically.

All of this will help to read and interpret our changlogs and release notes.
Here is a sample commit message: `feat(icm): my short commit description (#123)`

Chart unrelated commits (like e.g. docs, chore, build, test) will not be taken into account but still should be conventional and informative as possible.

All of this will help to read and interpret our changlogs and release notes.
2 changes: 1 addition & 1 deletion charts/icm-as/.bumpversion.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tool.bumpversion]
current_version = "2.5.0"
current_version = "2.5.1"

[[tool.bumpversion.files]]
filename = "Chart.yaml"
Expand Down
17 changes: 16 additions & 1 deletion charts/icm-as/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,26 @@

<a name="icm-as-2.5.1"></a>
## [icm-as-2.5.1](https://github.com/intershop/helm-charts/compare/icm-as-2.5.0...icm-as-2.5.1)

> 2025-01-09
### Chore

* bump versions of icm:patch icm-as:patch

### Docs

* **common:** link "Release Process"-wiki page to the contribution rules ([#867](https://github.com/intershop/helm-charts/issues/867))


<a name="icm-as-2.5.0"></a>
## [icm-as-2.5.0](https://github.com/intershop/helm-charts/compare/icm-as-2.4.1...icm-as-2.5.0)

> 2025-01-07
> 2025-01-08
### Chore

* generated changelog+release notes for icm-as:minor
* bump versions of icm-as:minor

### Feat
Expand Down
2 changes: 1 addition & 1 deletion charts/icm-as/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
# name and version must be in this exact order, otherwise bump2version won't work
name: icm-as
version: 2.5.0
version: 2.5.1
description: Intershop Commerce Management - AppServer
type: application
appVersion: 11.10.3-LTS
12 changes: 6 additions & 6 deletions charts/icm-as/RELEASE_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@

<a name="icm-as-2.5.0"></a>
## [icm-as-2.5.0](https://github.com/intershop/helm-charts/compare/icm-as-2.4.1...icm-as-2.5.0)
<a name="icm-as-2.5.1"></a>
## [icm-as-2.5.1](https://github.com/intershop/helm-charts/compare/icm-as-2.5.0...icm-as-2.5.1)

> 2025-01-07
> 2025-01-09
### Chore

* bump versions of icm-as:minor
* bump versions of icm:patch icm-as:patch

### Feat
### Docs

* **icm:** jgroups location directory configurable ([#865](https://github.com/intershop/helm-charts/issues/865))
* **common:** link "Release Process"-wiki page to the contribution rules ([#867](https://github.com/intershop/helm-charts/issues/867))

50 changes: 25 additions & 25 deletions charts/icm-as/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -337,13 +337,13 @@ persistence:
# Probes, all values are optional, below are the defaults
probes:
startup: {}
# failureThreshold: 6
# initialDelaySeconds: 60
# periodSeconds: 10
# failureThreshold: 6
# initialDelaySeconds: 60
# periodSeconds: 10
liveness: {}
# failureThreshold: 3
# initialDelaySeconds: 0
# periodSeconds: 10
# failureThreshold: 3
# initialDelaySeconds: 0
# periodSeconds: 10
readiness: {}
# failureThreshold: 3
# initialDelaySeconds: 0
Expand Down Expand Up @@ -527,27 +527,27 @@ replication:
# The following "source" and "targets" configuration blocks take precedence over
# the deprecated "targetSystemUrl" / "sourceDatabaseName" configurations
# Configuration for source system that participates in replication
# source:
# the external URL of the webServer/proxy/ingress e.g. https://icm-web-edit-wa:443
# webserverUrl: <sourceExternalUrl>
# either mutual exclusive databaseUser or databaseLink have to be configured
# databaseLink: <sourceDatabaseLink>
# databaseUser: <sourceDatabaseUser>
# databaseName: <sourceDatabaseName>
# source:
# # the external URL of the webServer/proxy/ingress e.g. https://icm-web-edit-wa:443
# webserverUrl: <sourceExternalUrl>
# # either mutual exclusive databaseUser or databaseLink have to be configured
# databaseLink: <sourceDatabaseLink>
# databaseUser: <sourceDatabaseUser>
# databaseName: <sourceDatabaseName>

# Configuration for all target systems that participates in replication
# targets:
# create multiple target systems - please avoid characters like '.', '-' or '_' in the chosen name/key
# live1:
# the external URL of the webServer/proxy/ingress e.g. https://icm-web-live-wa:443
# webserverUrl: <targetExternalUrl>
# this database user will be granted access to the database schema of the source replication system
# databaseUser: <targetDatabaseUser>
# live2:
# the external URL of the webServer/proxy/ingress e.g. https://icm-web-live-wa:443
# webserverUrl: <targetExternalUrl>
# this database user will be granted access to the database schema of the source replication system
# databaseUser: <targetDatabaseUser>
# targets:
# # create multiple target systems - please avoid characters like '.', '-' or '_' in the chosen name/key
# live1:
# # the external URL of the webServer/proxy/ingress e.g. https://icm-web-live-wa:443
# webserverUrl: <targetExternalUrl>
# # this database user will be granted access to the database schema of the source replication system
# databaseUser: <targetDatabaseUser>
# live2:
# # the external URL of the webServer/proxy/ingress e.g. https://icm-web-live-wa:443
# webserverUrl: <targetExternalUrl>
# # this database user will be granted access to the database schema of the source replication system
# databaseUser: <targetDatabaseUser>

# Configuration of messaging via jgroups
jgroups:
Expand Down
2 changes: 1 addition & 1 deletion charts/icm-replication/.bumpversion.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tool.bumpversion]
current_version = "2.10.0"
current_version = "2.10.1"

[[tool.bumpversion.files]]
filename = "Chart.yaml"
Expand Down
6 changes: 3 additions & 3 deletions charts/icm-replication/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@ appVersion: "11.9.0"
description: Intershop Commerce Management - ICM Replication
# name and version must be in this exact order, otherwise bump2version won't work
name: icm-replication
version: 2.10.0
version: 2.10.1
annotations:
requestedMemoryQuota: 9Gi
requestedCpuQuotaInMinutes: 3000
dependencies:
- name: icm
version: 2.10.0
version: 2.10.1
repository: file://../icm
alias: icm-live
- name: icm
version: 2.10.0
version: 2.10.1
repository: file://../icm
alias: icm-edit
2 changes: 1 addition & 1 deletion charts/icm/.bumpversion.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tool.bumpversion]
current_version = "2.10.0"
current_version = "2.10.1"

[[tool.bumpversion.files]]
filename = "Chart.yaml"
Expand Down
75 changes: 75 additions & 0 deletions charts/icm/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,86 @@

<a name="icm-2.10.1"></a>
## [icm-2.10.1](https://github.com/intershop/helm-charts/compare/icm-2.10.0...icm-2.10.1)

> 2025-01-09
### Chore

* bump versions of icm:patch icm-as:patch

### Docs

* **common:** link "Release Process"-wiki page to the contribution rules ([#867](https://github.com/intershop/helm-charts/issues/867))


<a name="icm-2.10.0"></a>
## [icm-2.10.0](https://github.com/intershop/helm-charts/compare/icm-2.9.1...icm-2.10.0)

> 2025-01-08
### Chore

* bump versions of icm-as:minor


<a name="icm-2.9.1"></a>
## [icm-2.9.1](https://github.com/intershop/helm-charts/compare/icm-2.9.0...icm-2.9.1)

> 2025-01-07
### Chore

* bump versions of icm-as:patch


<a name="icm-2.9.0"></a>
## [icm-2.9.0](https://github.com/intershop/helm-charts/compare/icm-2.8.1...icm-2.9.0)

> 2024-12-12
### Chore

* bump versions of icm-as:minor icm-web:patch


<a name="icm-2.8.1"></a>
## [icm-2.8.1](https://github.com/intershop/helm-charts/compare/icm-2.8.0...icm-2.8.1)

> 2024-11-26
### Chore

* bump versions of icm-web:patch


<a name="icm-2.8.0"></a>
## [icm-2.8.0](https://github.com/intershop/helm-charts/compare/icm-2.7.0...icm-2.8.0)

> 2024-11-25
### Chore

* bump versions of icm-web:minor


<a name="icm-2.7.0"></a>
## [icm-2.7.0](https://github.com/intershop/helm-charts/compare/icm-2.6.0...icm-2.7.0)

> 2024-11-22
### Chore

* bump versions of icm-as:minor icm-web:patch


<a name="icm-2.6.0"></a>
## [icm-2.6.0](https://github.com/intershop/helm-charts/compare/icm-2.5.2...icm-2.6.0)

> 2024-09-03
### Chore

* generated changelog+release notes for icm:minor icm-as:minor icm-replication:minor
* bump versions of icm:minor icm-as:minor icm-replication:minor

### Feat
Expand Down
4 changes: 2 additions & 2 deletions charts/icm/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ appVersion: "12.0.0"
description: Intershop Commerce Management - ICM
# name and version must be in this exact order, otherwise bump2version won't work
name: icm
version: 2.10.0
version: 2.10.1
# test related annotations
annotations:
requestedMemoryQuota: 6000Mi
requestedCpuQuotaInMinutes: "2200"
dependencies:
- name: icm-as
version: 2.5.0
version: 2.5.1
repository: file://../icm-as
- name: icm-web
version: 0.13.2
Expand Down
2 changes: 1 addition & 1 deletion charts/icm/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ Prerequisites are:
* [helm-unittest](https://github.com/helm-unittest/helm-unittest)

```bash
helm unittest --helm3 --output-file unit.xml --output-type JUnit charts/icm
helm unittest --output-file unit.xml --output-type JUnit charts/icm
```

### ct lint & install
Expand Down
12 changes: 6 additions & 6 deletions charts/icm/RELEASE_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@

<a name="icm-2.6.0"></a>
## [icm-2.6.0](https://github.com/intershop/helm-charts/compare/icm-2.5.2...icm-2.6.0)
<a name="icm-2.10.1"></a>
## [icm-2.10.1](https://github.com/intershop/helm-charts/compare/icm-2.10.0...icm-2.10.1)

> 2024-09-03
> 2025-01-09
### Chore

* bump versions of icm:minor icm-as:minor icm-replication:minor
* bump versions of icm:patch icm-as:patch

### Feat
### Docs

* **icm:** New replication environment configuration ([#803](https://github.com/intershop/helm-charts/issues/803))
* **common:** link "Release Process"-wiki page to the contribution rules ([#867](https://github.com/intershop/helm-charts/issues/867))

42 changes: 21 additions & 21 deletions charts/icm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ icm-as:
"cluster-autoscaler.kubernetes.io/safe-to-evict": "false"

image:
# repository: intershophub/icm-as
# tag: :11.0.12-dev1
# repository: intershophub/icm-as
# tag: :11.0.12-dev1

## define a secret for a container registry
dockerSecret:
Expand Down Expand Up @@ -75,27 +75,27 @@ icm-as:
# The following "source" and "targets" configuration blocks take precedence over
# the deprecated "targetSystemUrl" / "sourceDatabaseName" configurations
# Configuration for source system that participates in replication
# source:
# the external URL of the webServer/proxy/ingress e.g. https://icm-web-edit-wa:443
# webserverUrl: <sourceExternalUrl>
# either mutual exclusive databaseUser or databaseLink have to be configured
# databaseLink: <sourceDatabaseLink>
# databaseUser: <sourceDatabaseUser>
# databaseName: <sourceDatabaseName>
# source:
# # the external URL of the webServer/proxy/ingress e.g. https://icm-web-edit-wa:443
# webserverUrl: <sourceExternalUrl>
# # either mutual exclusive databaseUser or databaseLink have to be configured
# databaseLink: <sourceDatabaseLink>
# databaseUser: <sourceDatabaseUser>
# databaseName: <sourceDatabaseName>

# Configuration for all target systems that participates in replication
# targets:
# create multiple target systems - please avoid characters like '.', '-' or '_' in the chosen name/key
# live1:
# the external URL of the webServer/proxy/ingress e.g. https://icm-web-live-wa:443
# webserverUrl: <targetExternalUrl>
# this database user will be granted access to the database schema of the source replication system
# databaseUser: <targetDatabaseUser>
# live2:
# the external URL of the webServer/proxy/ingress e.g. https://icm-web-live-wa:443
# webserverUrl: <targetExternalUrl>
# this database user will be granted access to the database schema of the source replication system
# databaseUser: <targetDatabaseUser>
# targets:
# # create multiple target systems - please avoid characters like '.', '-' or '_' in the chosen name/key
# live1:
# # the external URL of the webServer/proxy/ingress e.g. https://icm-web-live-wa:443
# webserverUrl: <targetExternalUrl>
# # this database user will be granted access to the database schema of the source replication system
# databaseUser: <targetDatabaseUser>
# live2:
# # the external URL of the webServer/proxy/ingress e.g. https://icm-web-live-wa:443
# webserverUrl: <targetExternalUrl>
# # this database user will be granted access to the database schema of the source replication system
# databaseUser: <targetDatabaseUser>

icm-web:
enabled: true
Expand Down

0 comments on commit a34c6ee

Please sign in to comment.