feat(icm): enable serviceproviderclass on keyvault (#891) #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khauser
requested review from
skiesewetter-intershop,
MoritzKarsch and
tvalchev2
Test Results5 tests 5 ✅ 0s ⏱️ Results for commit 700d0dc. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Release
Be sure that pull requests are build according to the defined release process here. As a main part to mention here is that the semantic version type will be read from the commit messages (
BREAKING CHANGE(icm):marks a major change,feat(icm):marks minor changes and the rest will be patch. So the developer must already know and is responsible.What Is the Current Behavior?
A ServiceProviderClass has to be added manually to access keyvault keys, secrets or certificates.
Issue Number: Closes #891
What Is the New Behavior?
There is now a template for adding a ServiceProviderClass, which enables access to keys, secrets and certificates
Does this PR Introduce a Breaking Change?