-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR to fix my previous issues. #1277
Conversation
Related Issue: #1256 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hsyhhssyy Thank for the PR. I've added some suggestions below.
@gjsjohnmurray @isc-rsingh Can you take a look at this as well? I think the language of the new setting needs some work.
Co-authored-by: Brett Saviano <[email protected]>
Co-authored-by: Brett Saviano <[email protected]>
I've accepted these suggestions and committed new code. |
@hsyhhssyy Thanks for making the suggested changes! I'm getting ready to merge this PR, but one of our CI tests is failing due to linting issues. Can you run |
a3737cf
I have executed |
2872eb1
into
intersystems-community:master
Thanks @hsyhhssyy, I just merged your PR! |
The current version of the plugin still has several unresolved issues that I have encountered, detailed as follows:
To thoroughly address these issues, I have submitted this PR. The PR introduces a new VSCode option designed to prevent any automated Code Formatter actions without explicit user permission. Any write operations to code files not executed through the user's ContextMenu will be disabled.
Currently, it only acts on onDidCreateFiles to prevent the automatic addition of PackageNames to code. If further similar behaviors are identified in the future, I plan to extend its control scope. For instance, if an ObjectScript Lint is introduced later, the option would block the automatic application of Lint when saving files with Ctrl+S. Users would need to explicitly apply Lint by right-clicking in the file and selecting FormatCurrentFile.