Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new DTL Editor #1469

Merged
merged 6 commits into from
Mar 3, 2025

Conversation

isc-bsaviano
Copy link
Contributor

Next step for #60. IRIS 2025.1 will include the first version of the new DTL editor, and it supports embedding in VS Code. I will make this PR ready for review when there's a publicly available kit that can be used for testing.

@gjsjohnmurray
Copy link
Contributor

@isc-bsaviano no sign of the new editor in the most recent public preview:

IRIS for UNIX (Ubuntu Server LTS for x86-64 Containers) 2025.1 (Build 204U) Thu Feb 13 2025 16:06:36 EST

Our current release of this extension (2.12.10) was on Nov 13, 2024 and with betas we're now at 2.12.11-beta.14. When do you think we can publish a new version?

@isc-bsaviano
Copy link
Contributor Author

The new editor just missed the preview. It will be in the next one. This preview does have the fix for your Deltanji Rule Editor issue though. I would like to hold off on 3.0.0 until this can be merged.

@isc-bsaviano isc-bsaviano marked this pull request as ready for review March 3, 2025 16:30
@isc-bsaviano
Copy link
Contributor Author

I marked this as ready for review because the server-side change might not be publicly available until 2025.1 GA and we want to do the 30.0.0 release around then.

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based only on code reading.

@isc-bsaviano
Copy link
Contributor Author

Thanks John. My team and I have tested this so I'm confident that it works well.

@isc-bsaviano isc-bsaviano merged commit 9fd0b50 into intersystems-community:master Mar 3, 2025
5 checks passed
@isc-bsaviano isc-bsaviano deleted the dtl branch March 3, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants