Skip to content

Fix IDE editing of decomposed productions #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2025
Merged

Conversation

isc-pbarton
Copy link
Collaborator

fixes #643

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 64.28571% with 15 lines in your changes missing coverage. Please review.

Project coverage is 41.20%. Comparing base (cba24b5) to head (00451b8).

Files with missing lines Patch % Lines
cls/SourceControl/Git/Production.cls 63.41% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
+ Coverage   41.15%   41.20%   +0.04%     
==========================================
  Files          24       24              
  Lines        3188     3206      +18     
==========================================
+ Hits         1312     1321       +9     
- Misses       1876     1885       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


// only remove config item if it still exists and if item was opened ok
if $$$ISERR(sc) {
if '(sc [ "ErrConfigItemNotFound") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a more structured way to do this but on further consideration I don't care, this is more readable anyway!

@isc-tleavitt isc-tleavitt merged commit 9cb506b into main Apr 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production decomposition better support for IDE editing
3 participants