Skip to content

Commit

Permalink
Update version.py
Browse files Browse the repository at this point in the history 
"1.1.00" should be "1.1.0"
  • Loading branch information
@JosDenysGitHub
JosDenysGitHub authored Jun 25, 2021
1 parent a24b7f9 commit b30aa5f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion modules/iknowpy/iknowpy/version.py
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '1.1.00'
__version__ = '1.1.0'

1 comment on commit b30aa5f

@JosDenysGitHub
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are moving to version 1.1.0 because of a change in the API, the sentence attribute structure looked like this:

	struct Sent_Attribute:
		Attribute type "type_"
		size_t offset_start "offset_start_", offset_stop "offset_stop_"
		string marker "marker_"
		string value "value_", unit "unit_", value2 "value2_", unit2 "unit2_"
		Entity_Ref entity_ref
		Path entity_vector

The parameters value, unit, value2 and unit2 are fixed, and that needed to change. They're replaced with a list of pairs, holding the parameters:

	struct Sent_Attribute:
		Attribute type "type_"
		size_t offset_start "offset_start_", offset_stop "offset_stop_"
		string marker "marker_"
		Sent_Attribute_Parameters parameters "parameters_"
		Entity_Ref entity_ref
		Path entity_vector

The needed code changes are as follows:

sent_attribute['value'] = sent_attribute['parameters'][0][0]
sent_attribute['unit'] = sent_attribute['parameters'][0][1]
sent_attribute['value2'] = sent_attribute['parameters'][1][0]
sent_attribute['unit2'] = sent_attribute['parameters'][1][1]

This allows for a much more flexible use of sentence attribute parameters.

Please sign in to comment.