More v1 CI fixes #457
Closed
More v1 CI fixes #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes failures fatal Behavior is dependent on environment variables - need to see how this runs in real GitHub
Registry-dependent tests are now skipped if there's no registry. The integration test that uses simple-app was broken probably by some refactor of %ZHSLIB.AbstractInstaller-related things - added a stub installer class but we'll need to circle back to discussion of having such an interface defined in IPM itself because installer classes are important.
Update to 2024.1
Ports over some missing changes in %IPM.ResourceProcessor.Default.Document that seem to have been missed in past merging
e.g., the .DFI use cases from #380 I don't see where this drift happened internally but hopefully HS dev can provide some context.
These are now namespace-specific instead of global
Two commits because Windows is being annoying.
This was referenced Apr 25, 2024
Closed
|
Closing this one, will just do one review as part of #466 for simplicity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few more parts of #451 related to the verify phase and making test failures fatal again.
Basis is a branch with all the unit tests passing so we can get that far.