Add a module-version command that updates the version of a module
#710
+338
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-shuliu
changed the title
module-version command that updates the version of a module
isc-shuliu
requested review from
isc-kiyer,
isc-tleavitt,
isc-eneil,
isc-jili and
isc-jlechtne
and removed request for
isc-tleavitt
isc-kiyer
requested changes
Jan 22, 2025
and rename modifier -permit-downgrade to -force
isc-kiyer
reviewed
Jan 29, 2025
%Studio.AbstractDocument handles calling OnBeforeSave/OnAfterSave if %SourceControl is defined.
isc-eneil
approved these changes
Jan 29, 2025
isc-tleavitt
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
I think this is good after the typo fix. @isc-shuliu and I had a pair programming session today on the source control integration and have confirmed it working with the Perforce extension, although we found an issue there due to a changed return type - should be fixed in the Perforce extension itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #653
TODO