Load dependencies from .modules subfolder
#726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-kiyer
reviewed
Feb 4, 2025
|
While working on this PR, I noticed that a couple of test cases involving I changed the behavior of the |
isc-shuliu
requested review from
isc-kiyer,
isc-tleavitt,
isc-eneil,
isc-jili and
isc-jlechtne
isc-kiyer
reviewed
Feb 4, 2025
There was a problem hiding this comment.
@isc-shuliu few very minor comments. Looks great! We had discussed during the call today that this could also be supported for installing from a repo using the install command but in that case the local .modules directory would be used last in the ordering instead of first. Do you want to implement that in a separate review or this one?
isc-kiyer
approved these changes
Feb 5, 2025
isc-tleavitt
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #721.
With this PR, a temporary fs repo will be configured for
<package-folder>/.modulesif it exists, and automatically deleted when the loading finishes (even if it returned an error status code).The temporary repo is also the first in terms of priority for discovering packages.