Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop node v18 #2109

Merged
merged 1 commit into from
Feb 12, 2025
Merged

drop node v18 #2109

merged 1 commit into from
Feb 12, 2025

Conversation

babu-ch
Copy link
Contributor

@babu-ch babu-ch commented Feb 12, 2025

close #2099

hi
I saw a post on the chibivue server and came to help.
I confirmed that build and test are working.

Unclear points:
How to run tests in workflows
Do I also need to modify package.json under packages?

@kazupon kazupon added the Type: Breaking Includes backwards-incompatible fixes label Feb 12, 2025
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

Yeah, That's right!
Your contribution is so perfect! 💯
I'll merge your PR!

Thanks!

Copy link

Size Report

Bundles

File Size Gzip Brotli
core.esm-browser.prod.js 37.16 kB 11.35 kB 10.12 kB
core.global.prod.js 30.50 kB 10.55 kB 9.52 kB
core.prod.cjs 0.88 kB 0.43 kB 0.34 kB
core.runtime.esm-browser.prod.js 22.87 kB 7.45 kB 6.65 kB
core.runtime.global.prod.js 17.48 kB 6.81 kB 6.12 kB
message-compiler.esm-browser.prod.js 19.28 kB 5.76 kB 5.14 kB
message-compiler.global.prod.js 17.32 kB 5.54 kB 4.97 kB
message-compiler.prod.cjs 57.50 kB 10.06 kB 8.60 kB
petite-vue-i18n-core.esm-browser.prod.js 20.35 kB 6.84 kB 6.15 kB
petite-vue-i18n-core.global.prod.js 15.63 kB 6.05 kB 5.47 kB
petite-vue-i18n-core.prod.cjs 25.96 kB 6.14 kB 5.31 kB
petite-vue-i18n.esm-browser.prod.js 36.85 kB 11.32 kB 10.15 kB
petite-vue-i18n.global.prod.js 29.85 kB 10.18 kB 9.20 kB
petite-vue-i18n.prod.cjs 25.64 kB 6.05 kB 5.24 kB
petite-vue-i18n.runtime.esm-browser.prod.js 22.41 kB 7.32 kB 6.60 kB
petite-vue-i18n.runtime.global.prod.js 16.85 kB 6.41 kB 5.80 kB
vue-i18n.esm-browser.prod.js 56.42 kB 16.42 kB 14.68 kB
vue-i18n.global.prod.js 46.04 kB 14.87 kB 13.37 kB
vue-i18n.prod.cjs 0.72 kB 0.34 kB 0.28 kB
vue-i18n.runtime.esm-browser.prod.js 41.99 kB 12.43 kB 11.21 kB
vue-i18n.runtime.global.prod.js 33.03 kB 11.13 kB 10.05 kB

Usages

Name Size Gzip Brotli
packages/size-check-core (@intlify/core) 9.10 kB 3.76 kB 3.41 kB
packages/size-check-petite-vue-i18n (petite-vue-i18n) 77.81 kB 30.33 kB 27.29 kB
packages/size-check-vue-i18n (vue-i18n) 82.81 kB 31.74 kB 28.51 kB

Copy link

pkg-pr-new bot commented Feb 12, 2025

Open in Stackblitz

@intlify/core

npm i https://pkg.pr.new/@intlify/core@2109

@intlify/core-base

npm i https://pkg.pr.new/@intlify/core-base@2109

@intlify/message-compiler

npm i https://pkg.pr.new/@intlify/message-compiler@2109

@intlify/devtools-types

npm i https://pkg.pr.new/@intlify/devtools-types@2109

petite-vue-i18n

npm i https://pkg.pr.new/petite-vue-i18n@2109

@intlify/shared

npm i https://pkg.pr.new/@intlify/shared@2109

vue-i18n

npm i https://pkg.pr.new/vue-i18n@2109

@intlify/vue-i18n-core

npm i https://pkg.pr.new/@intlify/vue-i18n-core@2109

commit: ac62a92

@kazupon kazupon merged commit 159fdac into intlify:master Feb 12, 2025
28 checks passed
@babu-ch babu-ch deleted the feat/upd_node branch February 13, 2025 13:38
@babu-ch babu-ch mentioned this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking Includes backwards-incompatible fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drop Node v18
2 participants