switching latestReviews with reviews #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brownsarahm
reviewed
Oct 21, 2023
There was a problem hiding this comment.
So tested on your KWL, AymanBx:main gives you credit for only 16 badges, where main gives you 23. I am not going to accept this change as it is currently.
reviews I think gives the reviews in order from first to last where latestReviews is the other order.
I recommend first that you update your gh to make sure it is current and then run gh pr list --json to see the list of fields.
If there are truly up to date installs of gh that do not have latestReviews then we can do one of the following:
- check for both, use the one that exists and warn that
reviewsmay undercount - advise that this is only used with the version of
ghthat allows thelatestReviewsversion to work - update the json processing to dig deeper through the reviews to find the approval (right now it only reads the first one (which is the most recent one)
|
@AymanBx were you able to check the version/upgrade your version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Professor @brownsarahm,
A few students in lab today along with me had issues with retrieving approved badges using the specified command.
While investigating the reason I found that my version of gh CLI on WSL didn't have the option "latestReviews" as a query option.
While I didn't have time during lab today to check whether other students were facing a similar issue or just failed to do the correct setup to use the tools. I'm certain that my setup was fine, because after applying this fix locally I was able to use the command "sysapprovedbadges"
So if the difference between "latestReview" and "reviews" doesn't affect the outcome, I though I'd suggest the change.