-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify community badge procedures, closes #1 #2
Conversation
@brownsarahm looks good, but if I may make a couple of suggestions to make it look less vague. Possibly on lines (305-306) in badges.md it can say:
And in grading.md it can say: You will maintain a list of your contributions in your KWL repo in the |
Could you put those in as suggestions using the PR review features to add inline comments? This lets you practice with PR review features and is worth a second community badge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't know why I didn't think of that!
syllabus/grading.md
Outdated
- contributing extra terms or reviews to your team repo | ||
- sharing articles and discussing them in the course discussions | ||
- contributing annotated resources the course website | ||
|
||
You will maintain a list of your contributions in your KWL repo in the `community_contributions.md` file. All changes to this file should be submitted as a PR, with a review requested from @brownsarahm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will maintain a list of your contributions in your KWL repo in the community_contributions.md file. Every individual change to this file (representing one contribution) should be commited to a new branch and then submitted as a PR, with a review requested from @brownsarahm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Ayman Sandouk <[email protected]>
@AymanBx Can you confirm this answers your question?