Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify community badge procedures, closes #1 #2

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Conversation

brownsarahm
Copy link
Contributor

@brownsarahm brownsarahm commented Sep 20, 2023

  • adds community badge procedures from kwl template file
  • fixes a typo to lower experience badge requirement and clarify lab requirement in additional examples
  • clarifies title on some pages to make information easier to find

@AymanBx Can you confirm this answers your question?

@AymanBx
Copy link
Contributor

AymanBx commented Sep 20, 2023

@brownsarahm looks good, but if I may make a couple of suggestions to make it look less vague.

Possibly on lines (305-306) in badges.md it can say:

  • In the community_contributions.md file on your kwl repo, add an item in a bulleted list (start the line with - )
  • Include a link to your contribution like [text to display](url/of/contribution)

And in grading.md it can say:

You will maintain a list of your contributions in your KWL repo in the community_contributions.md file. Every individual change to this file (representing one contribution) should be commited to a new branch and then submitted as a PR, with a review requested from @brownsarahm.

@brownsarahm
Copy link
Contributor Author

Could you put those in as suggestions using the PR review features to add inline comments? This lets you practice with PR review features and is worth a second community badge.

Copy link
Contributor

@AymanBx AymanBx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't know why I didn't think of that!

- contributing extra terms or reviews to your team repo
- sharing articles and discussing them in the course discussions
- contributing annotated resources the course website

You will maintain a list of your contributions in your KWL repo in the `community_contributions.md` file. All changes to this file should be submitted as a PR, with a review requested from @brownsarahm.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will maintain a list of your contributions in your KWL repo in the community_contributions.md file. Every individual change to this file (representing one contribution) should be commited to a new branch and then submitted as a PR, with a review requested from @brownsarahm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make this a suggestion using the add a suggestion button ()
an icon a page with +- on it

(using that feature is the second badge worthy actitivy)

syllabus/grading.md Outdated Show resolved Hide resolved
syllabus/badges.md Outdated Show resolved Hide resolved
syllabus/badges.md Outdated Show resolved Hide resolved
Co-authored-by: Ayman Sandouk <[email protected]>
@brownsarahm brownsarahm merged commit 3abdf12 into main Sep 23, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants