#14 - Add proper support for string starts/ends operators #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiswalsk
approved these changes
Nov 18, 2021
| if (operator == Operator.CONTAINS || operator == Operator.STARTS || operator == Operator.ENDS ) { | ||
| if (operator == Operator.STARTS) { | ||
| expressionBuilder.append("'").append(expressionValues.get(0)).append("%").append("'"); | ||
| } else if (operator == Operator.ENDS) { |
There was a problem hiding this comment.
Lets add tests for these operators in the SQLExpressionTest file.
There was a problem hiding this comment.
👍 Added a test for each of those.
| case ENDS: | ||
| predicate = criteriaBuilder.like(path, "%" + operandValue.value()); | ||
| break; |
There was a problem hiding this comment.
Thanks for adding these cases.
jaiswalsk
approved these changes
Nov 19, 2021
|
Looks Good! 🚀 Thanks @roele for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue Link:
#14
2. Brief explanation of a change:
Implement START/END string operators instead of falling through CONTAINS.
3. Will it break existing clients and code in production?
Can possibly be considered a breaking change as behaviour will be more restrictive with this change.