Add null equality to EQ JPA expression visitor #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaiswalsk would you be able to review this PR? |
|
Thank you @tinawu0603 for the pull request. I will review this and share my feedback soon! Thanks. |
|
@jaiswalsk Do you have an update for this PR? 🙏 |
jaiswalsk
requested changes
Aug 31, 2022
pom.xml
Outdated
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| <groupId>com.intuit.graphql</groupId> | |||
| <artifactId>graphql-filter-java</artifactId> | |||
| <version>1.0.0-SNAPSHOT</version> | |||
There was a problem hiding this comment.
Can you please revert this changes, as it will be taken care during the release process.
jaiswalsk
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue Link:
#23
2. Brief explanation of a change:
Instead of assuming all values of
eqto usecriteriaBuilder.equal, if the value isnull, we want to usecriteriaBuilder.isNullinstead to create the right specification.3. Will it break existing clients and code in production?
No