Build frontend before running playwright tests

intuitem · Oct 2, 2024 · 1075936 · 1075936
1 parent e1a7972
commit 1075936
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/.github/workflows/functional-tests.yml b/.github/workflows/functional-tests.yml
@@ -98,6 +98,9 @@ jobs:
           export $(grep -v '^#' .env | xargs)
           python manage.py createsuperuser --noinput
           nohup python manage.py runserver &
+      - name: Build frontend
+        working-directory: ${{ env.frontend-directory }}
+        run: pnpm run build
       - name: Run tests with browser ${{ matrix.playwright-browser }}
         working-directory: ${{ env.frontend-directory }}
         run: pnpx playwright test --project=${{ matrix.playwright-browser }}
@@ -196,6 +199,9 @@ jobs:
           export $(grep -v '^#' .env | xargs)
           poetry run python manage.py createsuperuser --noinput
           nohup poetry run python manage.py runserver --settings=${{ env.enterprise-backend-settings-module }} &
+      - name: Build frontend
+        working-directory: ${{ env.frontend-directory }}
+        run: pnpm run build
       - name: Run tests with browser ${{ matrix.playwright-browser }}
         working-directory: ${{ env.enterprise-frontend-build-directory }}
         run: pnpx playwright test --project=${{ matrix.playwright-browser }}

diff --git a/.github/workflows/startup-tests.yml b/.github/workflows/startup-tests.yml
@@ -87,6 +87,9 @@ jobs:
           export $(grep -v '^#' .env | xargs)
           poetry run python manage.py createsuperuser --noinput
           nohup poetry run python manage.py runserver &
+      - name: Build frontend
+        working-directory: ${{ env.frontend-directory }}
+        run: pnpm run build
       - name: Run tests
         working-directory: ${{ env.frontend-directory }}
         run: pnpx playwright test tests/functional/startup.test.ts
@@ -214,6 +217,9 @@ jobs:
           export $(grep -v '^#' .env | xargs)
           poetry run python manage.py createsuperuser --noinput
           nohup poetry run python manage.py runserver --settings=${{ env.enterprise-backend-settings-module }} &
+      - name: Build frontend
+        working-directory: ${{ env.frontend-directory }}
+        run: pnpm run build
       - name: Run tests
         working-directory: ${{ env.enterprise-frontend-build-directory }}
         run: pnpx playwright test tests/functional/startup.test.ts

diff --git a/frontend/playwright.config.ts b/frontend/playwright.config.ts
@@ -3,10 +3,9 @@ import { devices } from '@playwright/test';
 
 const config: PlaywrightTestConfig = {
 	webServer: {
-		timeout: 2 * 60 * 1000,
 		command: process.env.COMPOSE_TEST
 			? 'echo "The docker compose frontend server didn\'t start correctly"'
-			: 'npm install -g pnpm && pnpm install && pnpm run build && pnpm run preview',
+			: 'pnpm run preview',
 		url: `http://localhost:${process.env.COMPOSE_TEST ? 3000 : 4173}`,
 		reuseExistingServer: !process.env.CI
 	},