Skip to content

Commit

Permalink
fix failing tests because of loading evidences attachment
Browse files Browse the repository at this point in the history
  • Loading branch information
Alexdev8 committed Feb 13, 2024
1 parent 080ce52 commit a5ddabe
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions frontend/tests/functional/detailed/common.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ for (const key of testPages) {

setHttpResponsesListener(page);

if (await pages[key].getRow("loading").first().isVisible()) {
await pages[key].getRow("loading").first().waitFor({state: 'hidden'});
}

await pages[key].createItem(items[key].build, "dependency" in items[key] ? items[key].dependency : null);

if (await pages[key].getRow(items[key].build.name).isHidden()) {
Expand Down
6 changes: 3 additions & 3 deletions frontend/tests/functional/nav.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ type StringMap = {
[key: string]: string;
};

test('sidebar navigation tests', async ({ logedPage, analyticsPage: overviewPage, sideBar, page }) => {
test('sidebar navigation tests', async ({ logedPage, analyticsPage, sideBar, page }) => {
test.slow();

await test.step('proper redirection to the overview page after login', async () => {
await overviewPage.hasUrl();
await overviewPage.hasTitle();
await analyticsPage.hasUrl();
await analyticsPage.hasTitle();
setHttpResponsesListener(page);
});

Expand Down
1 change: 0 additions & 1 deletion frontend/tests/functional/user-route.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ test('user usual routine actions are working correctly', async ({ logedPage, pag
description: vars.description,
attachment: vars.file,
folder: vars.folderName,
security_measures: [vars.securityMeasureName],
requirement_assessments: [
vars.requirement_assessment.name,
vars.requirement_assessment2.name
Expand Down
3 changes: 0 additions & 3 deletions frontend/tests/utils/test-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ export const test = base.extend<Fixtures>({
{ name: 'description', type: type.TEXT },
{ name: 'attachment', type: type.FILE },
{ name: 'folder', type: type.SELECT_AUTOCOMPLETE },
{ name: 'security_measures', type: type.SELECT_MULTIPLE_AUTOCOMPLETE },
{ name: 'requirement_assessments', type: type.SELECT_MULTIPLE_AUTOCOMPLETE },
{ name: 'link', type: type.TEXT },
]);
await use(ePage);
Expand Down Expand Up @@ -396,7 +394,6 @@ export class TestContent {
description: vars.description,
attachment: vars.file,
folder: vars.folderName,
security_measures: [vars.securityMeasureName],
requirement_assessments: [
vars.requirement_assessment.name,
vars.requirement_assessment2.name
Expand Down

0 comments on commit a5ddabe

Please sign in to comment.