Improve getPageTitle function

intuitem · Dec 20, 2024 · e8471b3 · e8471b3
1 parent f3609af
commit e8471b3
Showing 1 changed file with 17 additions and 5 deletions.
diff --git a/frontend/src/lib/components/Breadcrumbs/Breadcrumbs.svelte b/frontend/src/lib/components/Breadcrumbs/Breadcrumbs.svelte
@@ -18,12 +18,24 @@
 	}
 
 	function getPageTitle(): string {
-		return safeTranslate(
+		// Check each source in priority order
+		const title =
 			$page.data.title ??
-				($page.data.str || $page.data.name || $breadcrumbs.length > 1
-					? $breadcrumbs[$breadcrumbs.length - 1]?.label
-					: URL_MODEL_MAP[$page.url.pathname.split('/').pop() as string]?.verboseNamePlural)
-		);
+			$page.data.str ??
+			$page.data.name ??
+			getBreadcrumbTitle() ??
+			getUrlModelTitle();
+
+		return safeTranslate(title);
+	}
+
+	function getBreadcrumbTitle(): string | undefined {
+		return $breadcrumbs.length > 1 ? $breadcrumbs[$breadcrumbs.length - 1]?.label : undefined;
+	}
+
+	function getUrlModelTitle(): string | undefined {
+		const lastPathSegment = $page.url.pathname.split('/').pop() as string;
+		return URL_MODEL_MAP[lastPathSegment]?.localNamePlural;
 	}
 
 	afterNavigate(async () => {