Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing domain manager permissions #858

Conversation

melinoix
Copy link
Contributor

Domain manager permissions are changed to allow to create reference control inside his domain/sub-domains

Copy link
Contributor

@nas-tabchiche nas-tabchiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To do

Change {view,change,delete}_appliedcontrol to {view,change,delete}_referencecontrol.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task's subject was to allow the creation, edition and deletion of a ReferenceControl, not AppliedControl. Furthermore, view_appliedcontrol is present twice in the list. Once on line 132 and once on line 179.
For the first point, after reading my own comment under the ticket, I realized I wrote _appliedcontrol. My mistake. Still, a domain manager has no business managing applied controls 😉

Copy link
Collaborator

@eric-intuitem eric-intuitem Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it simple: a domain manager can do anything in its domain. The single exception is approval.
| Domain manager | full access to selected domains (except approval), in particular managing rights for these domains. Read access to global objects |

@nas-tabchiche
Copy link
Contributor

Closing this in favor of #893

@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants