Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing domain manager permissions #858

Closed
wants to merge 4 commits into from
Closed

Changing domain manager permissions #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a379d48
Changing domain manager permissions
melinoix Sep 23, 2024
8d74f12
corrected appliedcontrol to referencecontrol
melinoix Sep 24, 2024
e78f063
changing tests
melinoix Sep 24, 2024
996fee6
avoid redundant declaration
eric-intuitem Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions backend/core/startup.py
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task's subject was to allow the creation, edition and deletion of a ReferenceControl, not AppliedControl. Furthermore, view_appliedcontrol is present twice in the list. Once on line 132 and once on line 179.
For the first point, after reading my own comment under the ticket, I realized I wrote _appliedcontrol. My mistake. Still, a domain manager has no business managing applied controls 😉

Copy link
Collaborator

@eric-intuitem eric-intuitem Sep 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it simple: a domain manager can do anything in its domain. The single exception is approval.
| Domain manager | full access to selected domains (except approval), in particular managing rights for these domains. Read access to global objects |

Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@
"change_threat",
"delete_threat",
"view_referencecontrol",
"change_referencecontrol",
"delete_referencecontrol",
"view_folder",
"change_folder",
"add_riskmatrix",
Expand Down
5 changes: 4 additions & 1 deletion frontend/tests/utils/test-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,10 @@ export default {
'view_requirementnode',
'view_framework',
'view_loadedlibrary',
'view_user'
'view_user',
'view_referencecontrol',
'change_referencecontrol',
'delete_referencecontrol'
]
},
approver: {
Expand Down
Loading